[PATCH] [mips] [IAS] Add support for the .insn directive.
Daniel Sanders
daniel.sanders at imgtec.com
Wed Apr 15 09:12:23 PDT 2015
LGTM with a couple tiny nits. Thanks.
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:4059
@@ +4058,3 @@
+ // The actual label marking happens in
+ // MipsELFStreamer::createPendingLabelRelocs.
+ getTargetStreamer().emitDirectiveInsn();
----------------
Nit: There's usually '()' when referencing functions.
================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFStreamer.h:69
@@ +68,3 @@
+
+ /// Mark labels as microMIPS.
+ void createPendingLabelRelocs();
----------------
Nit: ... if necessary for the subtarget.
http://reviews.llvm.org/D8006
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list