[PATCH] [mips] [IAS] Refactor the function which checks for the availability of AT. NFC.

Daniel Sanders daniel.sanders at imgtec.com
Wed Apr 15 01:49:05 PDT 2015


LGTM


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2388
@@ +2387,3 @@
+unsigned MipsAsmParser::getATReg(SMLoc Loc) {
+  unsigned ATIndex = AssemblerOptions.back()->getATRegNum();
+  if (ATIndex == 0) {
----------------
We should correct this getATRegNum() function too since it really returns an index. That can be a follow-on patch if you prefer.

http://reviews.llvm.org/D8478

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list