[PATCH] [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned.

Rick Foos rfoos at codeaurora.org
Tue Apr 14 15:15:52 PDT 2015


svn r230575 via git...

TIMEOUT currently works with verbose log output. This patch just 
finishes the job.

We use it for exceptions from Pexpect that should not occur.

Not quite a FAIL, not quite a seg fault.

UNRESOLVED might be the DejaGnu equivalent failure, but that is cryptic 
as well.

Rick

git blame:

6b2822b2 (Daniel Dunbar    2013-02-01 01:39:53 +0000  20)   # These are 
the codes for which we will inc
6b2822b2 (Daniel Dunbar    2013-02-01 01:39:53 +0000  21)   # step results.
3dcd6abe (Ying Chen        2015-02-25 23:41:23 +0000  22) failingCodes = 
set(['FAIL', 'XPASS', 'KPASS...TIMEOUT
3dcd6abe (Ying Chen        2015-02-25 23:41:23 +0000  23)   # Regular 
expressions for start of summary
3dcd6abe (Ying Chen        2015-02-25 23:41:23 +0000  24) 
kStartSummaryRE = re.compile(r'^Failing Tes
6b2822b2 (Daniel Dunbar    2013-02-01 01:39:53 +0000  25)
3dcd6abe (Ying Chen        2015-02-25 23:41:23 +0000  26)   def 
__init__(self, maxLogs=None, parseSumma

git log:

commit 3dcd6abe8d85e186a2b74ecf544e4ec387efc7a8
Author: Ying Chen <chying at google.com>
Date:   Wed Feb 25 23:41:23 2015 +0000

     Modify LitLogObserver class to accept optional argument to parse 
summary lines only

     Summary:
     Modify LitLogObserver class to accept optional argument to parse 
summary lines only

     - This patch is to address the problem that regular stdio output 
messages be parsed as result steps
     - Add flag to start parser only after summary marker has been matched

     Test Plan:
     Create bulidbot master on local workstation
     Create slave and connect to local master
     Monitor the build status with check-ins

     Reviewers: sivachandra, ovyalov, chaoren

     Subscribers: llvm-commits

     Differential Revision: http://reviews.llvm.org/D7877

     git-svn-id: https://llvm.org/svn/llvm-project/zorg/trunk@230575 
91177308-0d34-0410-b5e6-96231b3b80d8



On 04/14/2015 04:47 PM, Jonathan Roelofs wrote:
> Grr. Phab totally didn't do the right thing there.... Here's the body of the reply that it ate:
>
> @rfoos: Do you have a reference to the commit where the TIMEOUT test result was added? @ddunbar asked me not to add that in http://reviews.llvm.org/D6584: "I would prefer that it not introduce a new failure code though, and just
> use FAIL with some extra message output".
>
> In other news, this is a good reminder that I need to finish http://reviews.llvm.org/D6584
>
> Cheers,
>
> Jon
>
>
> REPOSITORY
>    rL LLVM
>
> http://reviews.llvm.org/D9022
>
> EMAIL PREFERENCES
>    http://reviews.llvm.org/settings/panel/emailpreferences/
>
>

-- 
Rick Foos
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project




More information about the llvm-commits mailing list