[PATCH] Add support to promote f16 to f32
Pirama Arumuga Nainar
pirama at google.com
Tue Apr 14 10:34:32 PDT 2015
================
Comment at: test/CodeGen/Generic/fp16-promote.ll:1
@@ +1,2 @@
+; RUN: llc < %s
+
----------------
ab wrote:
> Some of the tests have half parameters and return types. I'm not sure that's expected to work on all targets, is it?
>
> If it's not, I still see value in a generic sanity check like this, so dealing with pointers instead is probably fine.
I agree that the tests here should take pointers.
I actually uploaded this as a placeholder for my initial patch. If it's ok, I'll delete the Generic tests in my next upload, and add them later. I need to commit the Mips patch (http://reviews.llvm.org/D8804) and upload a similar one for X86 before the tests will pass.
http://reviews.llvm.org/D8755
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list