[PATCH] [GlobalMerge] Look at uses to create smaller global sets.

Eric Christopher echristo at gmail.com
Tue Apr 14 08:17:32 PDT 2015


One nit, but at this point it looks good to me. I don't think I missed anything terrible algorithmically, but no one else has stepped up either.

-eric


================
Comment at: lib/CodeGen/GlobalMerge.cpp:267
@@ +266,3 @@
+
+    for (auto &U : GV->uses()) {
+      // This Use might be a ConstantExpr.  We're interested in instruction
----------------
Might be nice to comment the loops as to what they're each doing.

http://reviews.llvm.org/D8070

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list