[PATCH] Refactor: Simplify boolean expressions in ARM target

Richard legalize at xmission.com
Mon Apr 13 17:49:24 PDT 2015


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:5421
@@ -5420,3 +5420,3 @@
                      bool &CanAcceptCarrySet, bool &CanAcceptPredicationCode) {
-  if (Mnemonic == "and" || Mnemonic == "lsl" || Mnemonic == "lsr" ||
+  CanAcceptCarrySet = Mnemonic == "and" || Mnemonic == "lsl" || Mnemonic == "lsr" ||
       Mnemonic == "rrx" || Mnemonic == "ror" || Mnemonic == "sub" ||
----------------
rengolin wrote:
> Nitpick, maybe keep the Mnemonic on the next line, so it continues to align with the others.
Fixed; ran clang-format on the modified function.

http://reviews.llvm.org/D8524

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list