[llvm] r234721 - Revert r234615, "Have one raw_fd_ostream constructor forward to the other."

[NAKAMURA Takumi]

Author: chapuni
Date: Sun Apr 12 23:54:19 2015
New Revision: 234721

URL: http://llvm.org/viewvc/llvm-project?rev=234721&view=rev
Log:
Revert r234615, "Have one raw_fd_ostream constructor forward to the other."

It broke MSVCRT hosts:

  LLVM :: Object/check_binary_output.ll
  LLVM :: Object/extract.ll

Modified:
    llvm/trunk/lib/Support/raw_ostream.cpp

Modified: llvm/trunk/lib/Support/raw_ostream.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=234721&r1=234720&r2=234721&view=diff
==============================================================================
--- llvm/trunk/lib/Support/raw_ostream.cpp (original)
+++ llvm/trunk/lib/Support/raw_ostream.cpp Sun Apr 12 23:54:19 2015
@@ -487,41 +487,47 @@ void format_object_base::home() {
 //  raw_fd_ostream
 //===----------------------------------------------------------------------===//
 
-static int getFD(StringRef Filename, std::error_code &EC,
-                 sys::fs::OpenFlags Flags) {
+raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC,
+                               sys::fs::OpenFlags Flags)
+    : Error(false), UseAtomicWrites(false), pos(0) {
+  EC = std::error_code();
   // Handle "-" as stdout. Note that when we do this, we consider ourself
   // the owner of stdout. This means that we can do things like close the
   // file descriptor when we're done and set the "binary" flag globally.
   if (Filename == "-") {
-    EC = std::error_code();
+    FD = STDOUT_FILENO;
     // If user requested binary then put stdout into binary mode if
     // possible.
     if (!(Flags & sys::fs::F_Text))
       sys::ChangeStdoutToBinary();
-    return STDOUT_FILENO;
+    // Close stdout when we're done, to detect any output errors.
+    ShouldClose = true;
+    return;
   }
 
-  int FD;
   EC = sys::fs::openFileForWrite(Filename, FD, Flags);
-  if (EC)
-    return -1;
 
-  return FD;
-}
+  if (EC) {
+    ShouldClose = false;
+    return;
+  }
 
-raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC,
-                               sys::fs::OpenFlags Flags)
-    : raw_fd_ostream(getFD(Filename, EC, Flags), true) {}
+  // Ok, we successfully opened the file, so it'll need to be closed.
+  ShouldClose = true;
+}
 
 /// FD is the file descriptor that this writes to.  If ShouldClose is true, this
 /// closes the file when the stream is destroyed.
 raw_fd_ostream::raw_fd_ostream(int fd, bool shouldClose, bool unbuffered)
-  : raw_ostream(unbuffered), FD(fd),
-    ShouldClose(shouldClose), Error(false), UseAtomicWrites(false) {
-  if (FD < 0 ) {
-    ShouldClose = false;
-    return;
-  }
+    : raw_ostream(unbuffered), FD(fd), ShouldClose(shouldClose), Error(false),
+      UseAtomicWrites(false) {
+#ifdef O_BINARY
+  // Setting STDOUT to binary mode is necessary in Win32
+  // to avoid undesirable linefeed conversion.
+  // Don't touch STDERR, or w*printf() (in assert()) would barf wide chars.
+  if (fd == STDOUT_FILENO)
+    setmode(fd, O_BINARY);
+#endif
 
   // Get the starting position.
   off_t loc = ::lseek(FD, 0, SEEK_CUR);