[PATCH] [SCEV] Extract and strengthen isHighCostExpansion.

[Daniel Berlin]

On Sun, Apr 12, 2015 at 12:03 PM, Sanjoy Das
<sanjoy at playingwithpointers.com> wrote:
>> It's kind of nice to move code in a separate change from updating it, so
>> that it's easier to see what actually changed.
>
> Done.  The NFCI part is in D8995.
>
>> We don't usually repeat the function name in the doc comment for new
>> code.
>
> I went with it since that is the convention in the rest of the file.
> If it is okay with you, I'd prefer fixing this by submitting this
> change as is and fixing the whole ScalarEvolutionExpander.h file at
> once in an NFC commit.  Also, I could not easily find this in
> CodingStandards.html -- should this clause be added there?

"Don’t duplicate function or class name at the beginning of the
comment. For humans it is obvious which function or class is being
documented; automatic documentation processing tools are smart enough
to bind the comment to the correct declaration.

It has an example below it :)

>
> -- Sanjoy
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits