[PATCH] [RewriteStatepointsForGC] Use an actual liveness algorithm

Philip Reames listmail at philipreames.com
Fri Apr 10 15:54:49 PDT 2015


I'm about to submit this with the minor fixes you mentioned applied.  The change of data structure will go in separately and I haven't added the expensive asserts yet.  (Let me know if you want these.)


================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:2076
@@ +2075,3 @@
+    }
+    // assert OutLiveOut is a subset of LiveOut
+    if (OldLiveOutSize == LiveOut.size()) {
----------------
sanjoy wrote:
> ? Please actually add an assert. :)
Checking this makes Release+Asserts *really* slow.  I can put an assert under expensive asserts if you'd like.  I see the main value is the documentation, not the actual check.

http://reviews.llvm.org/D8674

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list