[PATCH] Split Mprotect into MmapNoAccess and MprotectNoAccess to be more portable

H.J Lu hjl.tools at gmail.com
Fri Apr 10 14:50:37 PDT 2015


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:132
@@ +131,3 @@
+  return internal_syscall(SYSCALL(mprotect), addr, length, prot);
+}
+
----------------
This is incorrect on Linux/x86-64.  Pointers passed to
internal_syscall should be casted to uptr first.  Otherwise,
they won't be properly extended to 64-bit for x32.  Need
something like

return internal_syscall(SYSCALL(mprotect), (uptr)addr, length, prot);

http://reviews.llvm.org/D8970

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list