[PATCH] WIP: AddDiscriminators: Check more carefully for equivalent locations

Diego Novillo dnovillo at google.com
Fri Apr 10 10:21:19 PDT 2015


On Fri, Apr 10, 2015 at 1:16 PM, Eric Christopher <echristo at gmail.com> wrote:
> Since I'm not sure you're on IRC...
>
> If we have column information that's just as good as file and line for
> discriminating. If those are also the same and we have different basic
> blocks then we need a discriminator. I don't think that anyone is trying to
> remove discriminators, just if we have column information we can use that
> too?

Absolutely agreed. If we want to reduce the amount of discriminator
info generated, I don't mind. I only care about being able to
distinguish different basic blocks within the same LOC entry
(regardless of how they ended up sharing the same LOC entry).


Diego.



More information about the llvm-commits mailing list