LGTM with a formatting nit. ================ Comment at: lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp:124 @@ +123,2 @@ +} + ---------------- Extra line at EOF. http://reviews.llvm.org/D8972 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/