[PATCH] Add direct moves to/from VSR and exploit them for FP/INT conversions

[Eric Christopher]

Couple of inline questions, please do fix up all of the comments to be complete sentences. Bill looks like he has the rest of the correctness issues.

Thanks!

-eric


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:5917
@@ -5913,1 +5916,3 @@
 
+SDValue PPCTargetLowering::LowerFP_TO_INTDirectMove(SDValue Op,
+                                                    SelectionDAG &DAG,
----------------
Block comment before the function please.

================
Comment at: test/CodeGen/PowerPC/fp-int-conversions-direct-moves.ll:1-2
@@ +1,3 @@
+; RUN: llc -mcpu=pwr8 -mtriple=powerpc64-unknown-linux-gnu < %s | FileCheck %s
+; RUN: llc -mcpu=pwr8 -mtriple=powerpc64le-unknown-linux-gnu < %s | FileCheck %s
+
----------------
Can probably just use -unknown-unknown here as the OS part of the triple?

================
Comment at: test/CodeGen/PowerPC/stfiwx.ll:1-2
@@ -1,3 +1,3 @@
-; RUN: llc < %s -march=ppc32 -mtriple=powerpc-apple-darwin8 -mattr=stfiwx | FileCheck %s
-; RUN: llc < %s -march=ppc32 -mtriple=powerpc-apple-darwin8 -mattr=-stfiwx | FileCheck -check-prefix=CHECK-LS %s
+; RUN: llc < %s -march=ppc32 -mattr=-direct-move -mtriple=powerpc-apple-darwin8 -mattr=stfiwx | FileCheck %s
+; RUN: llc < %s -march=ppc32 -mattr=-direct-move -mtriple=powerpc-apple-darwin8 -mattr=-stfiwx | FileCheck -check-prefix=CHECK-LS %s
 
----------------
How is direct-move getting turned on? I thought it was power8 only?

http://reviews.llvm.org/D8928

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/