[PATCH] [libcxx] std::codecvt - short wchar support

Marshall Clow mclow.lists at gmail.com
Wed Apr 8 21:49:31 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: src/locale.cpp:1877
@@ -1946,2 +1876,3 @@
+              _ToType* to, _ToType* to_end, _ToType*& to_nxt,
               unsigned long Maxcode = 0x10FFFF, codecvt_mode mode = codecvt_mode(0))
 {
----------------
mclow.lists wrote:
> You're changing a function named `utf8_to_utf16` to take parameters of type `uint32_t *`?
> 
> Eww.  I object.
I apologize for this comment. We already have a function that does this.
Still, eww.

http://reviews.llvm.org/D8880

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list