[llvm] r234439 - Pass -mtriple to llc to appease buildbot.

Akira Hatanaka ahatanak at gmail.com
Wed Apr 8 15:30:21 PDT 2015


Probably that's better. I'll see if I can change the check string instead.

On Wed, Apr 8, 2015 at 3:19 PM, Eric Christopher <echristo at gmail.com> wrote:

> I'd probably change the check string to avoid overconditionalizing the
> test.
>
> -eric
>
> On Wed, Apr 8, 2015 at 3:14 PM Akira Hatanaka <ahatanak at gmail.com> wrote:
>
>> It looks like AArch64's instprinter is making the difference. Apple's
>> aarch64 instprinter prints LDi32 as "ld1.s" whereas the base aarch64
>> instprinter prints "ld1".
>>
>> I believe dagcombine doesn't have platform dependence in this case
>> (before checking in the fix to dagcombine, test case would have crashed on
>> both apple and linux platforms), so I didn't think it was necessary to
>> avoid usiing mtriple. Alternatively, changing the check string would have
>> worked too.
>>
>> On Wed, Apr 8, 2015 at 2:47 PM, Eric Christopher <echristo at gmail.com>
>> wrote:
>>
>>> Is the register allocation OS dependent? Is it that the actual cpu here
>>> is cyclone?
>>>
>>> -eric
>>>
>>> On Wed, Apr 8, 2015 at 2:36 PM Akira Hatanaka <ahatanaka at apple.com>
>>> wrote:
>>>
>>>> Author: ahatanak
>>>> Date: Wed Apr  8 16:30:48 2015
>>>> New Revision: 234439
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=234439&view=rev
>>>> Log:
>>>> Pass -mtriple to llc to appease buildbot.
>>>>
>>>> This fixes the test case I committed in r234430.
>>>>
>>>> Modified:
>>>>     llvm/trunk/test/CodeGen/AArch64/merge-store.ll
>>>>
>>>> Modified: llvm/trunk/test/CodeGen/AArch64/merge-store.ll
>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
>>>> CodeGen/AArch64/merge-store.ll?rev=234439&r1=234438&r2=234439&view=diff
>>>> ============================================================
>>>> ==================
>>>> --- llvm/trunk/test/CodeGen/AArch64/merge-store.ll (original)
>>>> +++ llvm/trunk/test/CodeGen/AArch64/merge-store.ll Wed Apr  8 16:30:48
>>>> 2015
>>>> @@ -1,4 +1,4 @@
>>>> -; RUN: llc -march=aarch64 %s -o - | FileCheck %s
>>>> +; RUN: llc -mtriple=arm64-apple-ios7.0 %s -o - | FileCheck %s
>>>>
>>>>  @g0 = external global <3 x float>, align 16
>>>>  @g1 = external global <3 x float>, align 4
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150408/998b096b/attachment.html>


More information about the llvm-commits mailing list