[PATCH] [zorg] Lit parser should ignore leading whitespace in log file.
Rick Foos
rfoos at codeaurora.org
Wed Apr 8 11:43:19 PDT 2015
REPOSITORY
rL LLVM
================
Comment at: zorg/buildbot/commands/LitTestCommand.py:51
@@ -50,3 +50,3 @@
# If this is a stop marker, process the test info.
- if self.kTestVerboseLogStopRE.match(line):
+ if self.kTestVerboseLogStopRE.match(line.strip()):
self.testInfoFinished()
----------------
gkistanova wrote:
> lstrip() if you really want to remove the leading whitespace.
I agree, lstrip is more correct.
strip should to lstrip + rstrip.
I used strip because the StartRE, and TestLineRE also use strip.
m = self.kTestVerboseLogStartRE.match(line.strip())
m = self.kTestLineRE.match(line.strip())
Should I
- leave the strip on stopRE
- Change the three RE's to lstrip
- change only the stopRE to lstrip.
http://reviews.llvm.org/D8878
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list