[lld] r234378 - Allow undefined symbols in shared library by default.

Simon Atanasyan simon at atanasyan.com
Tue Apr 7 23:11:37 PDT 2015


It looks like we have test case already. The broken test case :-)

http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/9537

On Wed, Apr 8, 2015 at 4:42 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> testcase :-)
>
> On 7 April 2015 at 21:00, Davide Italiano <davide at freebsd.org> wrote:
>> Author: davide
>> Date: Tue Apr  7 20:00:19 2015
>> New Revision: 234378
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=234378&view=rev
>> Log:
>> Allow undefined symbols in shared library by default.
>>
>> It's not our business to resolve those undefined symbols.
>> We just trust the linker will load the library and its dependencies
>> correctly, which is actually what happens, modulo bugs in the dynamic
>> linker itself.
>>
>> PR:             23035
>> Differential Revision:  http://reviews.llvm.org/D8886
>>
>> Modified:
>>     lld/trunk/lib/Core/LinkingContext.cpp
>>
>> Modified: lld/trunk/lib/Core/LinkingContext.cpp
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/LinkingContext.cpp?rev=234378&r1=234377&r2=234378&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/Core/LinkingContext.cpp (original)
>> +++ lld/trunk/lib/Core/LinkingContext.cpp Tue Apr  7 20:00:19 2015
>> @@ -24,7 +24,7 @@ LinkingContext::LinkingContext()
>>        _warnIfCoalesableAtomsHaveDifferentCanBeNull(false),
>>        _warnIfCoalesableAtomsHaveDifferentLoadName(false),
>>        _printRemainingUndefines(true), _allowRemainingUndefines(false),
>> -      _logInputFiles(false), _allowShlibUndefines(false),
>> +      _logInputFiles(false), _allowShlibUndefines(true),
>>        _outputFileType(OutputFileType::Default), _nextOrdinal(0) {}
>>
>>  LinkingContext::~LinkingContext() {}
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



-- 
Simon Atanasyan




More information about the llvm-commits mailing list