[PATCH] Handling store to invariant address in LAA
Nema, Ashutosh
Ashutosh.Nema at amd.com
Tue Apr 7 21:31:38 PDT 2015
> ================
> Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1037
> @@ -1046,1 +1036,3 @@
> + // Check for store to loop invariant address.
> + StoreToLoopInvariantAddress = isUniform(Ptr);
> // If we did *not* see this pointer before, insert it to the read-write
> ----------------
> Ashutosh,
> I think this should be |= rather than =.
Yes, that’s the problem.
I'll fix this, and update you.
Did you reverted 234361 ?
Regards,
Ashutosh
-----Original Message-----
From: Adam Nemet [mailto:anemet at apple.com]
Sent: Wednesday, April 08, 2015 9:58 AM
To: Nema, Ashutosh; hfinkel at anl.gov; listmail at philipreames.com; anemet at apple.com
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Handling store to invariant address in LAA
REPOSITORY
rL LLVM
================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1037
@@ -1046,1 +1036,3 @@
+ // Check for store to loop invariant address.
+ StoreToLoopInvariantAddress = isUniform(Ptr);
// If we did *not* see this pointer before, insert it to the read-write
----------------
Ashutosh,
I think this should be |= rather than =.
http://reviews.llvm.org/D8653
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list