[PATCH] [InstCombine][CodeGenPrep] Create llvm.uadd.with.overflow in CGP.

[David Majnemer]

Just some quick drive-by comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:756-757
@@ +755,4 @@
+  Value *AddV, *A, *B;
+  if (match(CI, m_UAddWithOverflow(m_Value(A), m_Value(B), m_Value(AddV))) &&
+      isa<IntegerType>(AddV->getType()) && isa<Instruction>(AddV)) {
+    Module *M = CI->getParent()->getParent()->getParent();
----------------
We should probably have an `m_Instruction`.

================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:778
@@ -751,1 +777,3 @@
+
+/// SinkCmpExpression - sink the given CmpInst into user blocks to reduce
 /// the number of virtual registers that must be created and coalesced.  This is
----------------
Please capitalize sink.

http://reviews.llvm.org/D8889

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/