[PATCH] [ELF] Allow customization of OutputELFWriter class

Rui Ueyama ruiu at google.com
Tue Apr 7 16:43:05 PDT 2015


Hm. So this patch apparently solves the issue you described but with a (non-obvious) template magic to insert a class to a class hierarchy. This complexity made me a bit nervous, so I thought about alternatives for a while.

The first thing that came up to my mind is to use utility functions you described, but with that you cannot purge duplicates. The other way would be to use multiple inheritance, but that's worse than the template magic. After all, this patch removes 170 lines, so maybe it's a good hack.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8882

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list