[lld] r234357 - [ELF] Remove unused xxxWriter class fields
Simon Atanasyan
simon at atanasyan.com
Tue Apr 7 14:12:18 PDT 2015
Author: atanasyan
Date: Tue Apr 7 16:12:18 2015
New Revision: 234357
URL: http://llvm.org/viewvc/llvm-project?rev=234357&view=rev
Log:
[ELF] Remove unused xxxWriter class fields
Modified:
lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h
lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h
lld/trunk/lib/ReaderWriter/ELF/X86/X86ExecutableWriter.h
lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h
Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h?rev=234357&r1=234356&r2=234357&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h Tue Apr 7 16:12:18 2015
@@ -34,15 +34,12 @@ private:
};
std::unique_ptr<GOTFile> _gotFile;
- AArch64LinkingContext &_ctx;
- TargetLayout<ELFT> &_layout;
};
template <class ELFT>
AArch64DynamicLibraryWriter<ELFT>::AArch64DynamicLibraryWriter(
AArch64LinkingContext &ctx, TargetLayout<ELFT> &layout)
- : DynamicLibraryWriter<ELFT>(ctx, layout), _gotFile(new GOTFile(ctx)),
- _ctx(ctx), _layout(layout) {}
+ : DynamicLibraryWriter<ELFT>(ctx, layout), _gotFile(new GOTFile(ctx)) {}
template <class ELFT>
void AArch64DynamicLibraryWriter<ELFT>::createImplicitFiles(
Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h?rev=234357&r1=234356&r2=234357&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h Tue Apr 7 16:12:18 2015
@@ -33,22 +33,19 @@ private:
};
std::unique_ptr<GOTFile> _gotFile;
- AArch64LinkingContext &_ctx;
- TargetLayout<ELFT> &_layout;
};
template <class ELFT>
AArch64ExecutableWriter<ELFT>::AArch64ExecutableWriter(
AArch64LinkingContext &ctx, TargetLayout<ELFT> &layout)
- : ExecutableWriter<ELFT>(ctx, layout), _gotFile(new GOTFile(ctx)),
- _ctx(ctx), _layout(layout) {}
+ : ExecutableWriter<ELFT>(ctx, layout), _gotFile(new GOTFile(ctx)) {}
template <class ELFT>
void AArch64ExecutableWriter<ELFT>::createImplicitFiles(
std::vector<std::unique_ptr<File>> &result) {
ExecutableWriter<ELFT>::createImplicitFiles(result);
_gotFile->addAtom(*new (_gotFile->_alloc) GlobalOffsetTableAtom(*_gotFile));
- if (_ctx.isDynamic())
+ if (this->_ctx.isDynamic())
_gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
result.push_back(std::move(_gotFile));
}
Modified: lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h?rev=234357&r1=234356&r2=234357&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h Tue Apr 7 16:12:18 2015
@@ -32,15 +32,12 @@ private:
};
std::unique_ptr<GOTFile> _gotFile;
- X86LinkingContext &_ctx;
- TargetLayout<ELFT> &_layout;
};
template <class ELFT>
X86DynamicLibraryWriter<ELFT>::X86DynamicLibraryWriter(
X86LinkingContext &ctx, TargetLayout<ELFT> &layout)
- : DynamicLibraryWriter<ELFT>(ctx, layout), _gotFile(new GOTFile(ctx)),
- _ctx(ctx), _layout(layout) {}
+ : DynamicLibraryWriter<ELFT>(ctx, layout), _gotFile(new GOTFile(ctx)) {}
template <class ELFT>
void X86DynamicLibraryWriter<ELFT>::createImplicitFiles(
Modified: lld/trunk/lib/ReaderWriter/ELF/X86/X86ExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86/X86ExecutableWriter.h?rev=234357&r1=234356&r2=234357&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86/X86ExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86/X86ExecutableWriter.h Tue Apr 7 16:12:18 2015
@@ -23,16 +23,12 @@ public:
protected:
// Add any runtime files and their atoms to the output
void createImplicitFiles(std::vector<std::unique_ptr<File>> &) override;
-
-private:
- X86LinkingContext &_ctx;
- TargetLayout<ELFT> &_layout;
};
template <class ELFT>
X86ExecutableWriter<ELFT>::X86ExecutableWriter(X86LinkingContext &ctx,
TargetLayout<ELFT> &layout)
- : ExecutableWriter<ELFT>(ctx, layout), _ctx(ctx), _layout(layout) {}
+ : ExecutableWriter<ELFT>(ctx, layout) {}
template <class ELFT>
void X86ExecutableWriter<ELFT>::createImplicitFiles(
Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h?rev=234357&r1=234356&r2=234357&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h Tue Apr 7 16:12:18 2015
@@ -19,7 +19,7 @@ namespace elf {
class X86_64ExecutableWriter : public ExecutableWriter<X86_64ELFType> {
public:
X86_64ExecutableWriter(X86_64LinkingContext &ctx, X86_64TargetLayout &layout)
- : ExecutableWriter(ctx, layout), _gotFile(new GOTFile(ctx)), _ctx(ctx) {}
+ : ExecutableWriter(ctx, layout), _gotFile(new GOTFile(ctx)) {}
protected:
// Add any runtime files and their atoms to the output
@@ -28,7 +28,7 @@ protected:
ExecutableWriter::createImplicitFiles(result);
_gotFile->addAtom(*new (_gotFile->_alloc)
GlobalOffsetTableAtom(*_gotFile));
- if (_ctx.isDynamic())
+ if (this->_ctx.isDynamic())
_gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
result.push_back(std::move(_gotFile));
}
@@ -41,7 +41,6 @@ private:
};
std::unique_ptr<GOTFile> _gotFile;
- X86_64LinkingContext &_ctx;
};
} // namespace elf
More information about the llvm-commits
mailing list