[PATCH] [DAGCombine] Fix bug in MergeConsecutiveStores

Tim Northover t.p.northover at gmail.com
Tue Apr 7 13:05:17 PDT 2015


> It's not clear to me that choosing the last store is the correct solution...


We already check memory aliasing before calling MergeStoresOfConstantsOrVecElts, so I think only direct data dependence matters; but stores to not produce any (non-chain) values so moving them later can't create a loop.

So I think the patch is essentially sound.

Tim.


http://reviews.llvm.org/D8849

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list