[PATCH] [06/10] ELF/AArch64: Check linker created dynamic variables

Rui Ueyama ruiu at google.com
Tue Apr 7 09:28:32 PDT 2015


LGTM


================
Comment at: test/elf/AArch64/dynamicvars.test:6
@@ +5,3 @@
+#RUN: lld -flavor gnu  -target aarch64 -e main %t.o -o %t1 --noinhibit-exec
+#RUN: llvm-readobj -sections -symbols %t1 | FileCheck -check-prefix CHECKSYMS %s
+
----------------
nit: put a space after the hashes.

You can remove "-check-prefix CHECKSYMS" from this command line and s/CHECKSYMS/CHECK/ below because this file contains only one FileCheck.

================
Comment at: test/elf/AArch64/dynamicvars.test:20
@@ +19,3 @@
+#CHECKSYMS:    Value: [[TARGETB]]
+#CHECKSYMS:    Section: .got.plt
+
----------------
ditto

http://reviews.llvm.org/D8865

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list