[PATCH] [ELF] Simplify adding default atoms
Rui Ueyama
ruiu at google.com
Tue Apr 7 09:14:03 PDT 2015
Thank you for doing this. This is a nice cleanup. LGTM.
REPOSITORY
rL LLVM
================
Comment at: lib/ReaderWriter/ELF/DynamicLibraryWriter.h:64
@@ +63,3 @@
+ auto file = llvm::make_unique<RuntimeFile<ELFT>>(this->_ctx, "C runtime");
+ file->addAbsoluteAtom("_end");
+ result.push_back(std::move(file));
----------------
addAbsoluteAtom returns a pointer to a new atom, so we discard the pointer here. Looks like we don't use return values from the function at all. This doesn't have to be done in this patch, but we should make the function return void.
http://reviews.llvm.org/D8852
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list