[PATCH] [lld][ELF][ARM] Mapping symbols for PLT entries

Denis Protivensky dprotivensky at accesssoftek.com
Mon Apr 6 00:20:14 PDT 2015


Concerning different output when compiling with NDEBUG: these extra symbols do really help debugging sometimes. That's a good way to check that some call refers PLT entry, or veneer is used for some operations. I treat these symbol names as extra debug output and nothing more.


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:71
@@ +70,3 @@
+  case DefinedAtom::codeARM_a:
+    name = "$a";
+    break;
----------------
ruiu wrote:
> Maybe replacing this line (and similar lines) with a return statement could make this code a bit concise? (I didn't try myself, so I don't know how it would look like -- it's up to you.)
> 
>   return part.empty() ? "$a" : "$a." + part;
> 
I'll take it into account.

http://reviews.llvm.org/D8819

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list