[PATCH] [lld][ELF][ARM] Mapping symbols for PLT entries

Rui Ueyama ruiu at google.com
Fri Apr 3 11:21:09 PDT 2015


The code generally looks good, but I'm wondering if it's a good thing to link an executable in a different way only when the linker itself was compiled with NDEBUG. Should the debug flag affects outputs?

I saw this pattern in many places in the ELF port of the LLD, so this comment is not actually specific to your patch, though.


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:71
@@ +70,3 @@
+  case DefinedAtom::codeARM_a:
+    name = "$a";
+    break;
----------------
Maybe replacing this line (and similar lines) with a return statement could make this code a bit concise? (I didn't try myself, so I don't know how it would look like -- it's up to you.)

  return part.empty() ? "$a" : "$a." + part;

http://reviews.llvm.org/D8819

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list