[lld] r233924 - [Mips] Inline the MipsELFWriter::hasGlobalGOTEntry function
Simon Atanasyan
simon at atanasyan.com
Thu Apr 2 09:44:27 PDT 2015
Author: atanasyan
Date: Thu Apr 2 11:44:26 2015
New Revision: 233924
URL: http://llvm.org/viewvc/llvm-project?rev=233924&view=rev
Log:
[Mips] Inline the MipsELFWriter::hasGlobalGOTEntry function
No functional changes.
Modified:
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h?rev=233924&r1=233923&r2=233924&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h Thu Apr 2 11:44:26 2015
@@ -47,10 +47,6 @@ public:
setAtomValue("__gnu_local_gp", gp);
}
- bool hasGlobalGOTEntry(const Atom *a) const {
- return _targetLayout.getGOTSection().hasGlobalGOTEntry(a);
- }
-
std::unique_ptr<RuntimeFile<ELFT>> createRuntimeFile() {
auto file = llvm::make_unique<RuntimeFile<ELFT>>(_ctx, "Mips runtime file");
if (_ctx.isDynamic()) {
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h?rev=233924&r1=233923&r2=233924&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h Thu Apr 2 11:44:26 2015
@@ -74,7 +74,7 @@ void MipsExecutableWriter<ELFT>::buildDy
for (auto sec : this->_layout.sections())
if (auto section = dyn_cast<AtomSection<ELFT>>(sec))
for (const auto &atom : section->atoms()) {
- if (_writeHelper.hasGlobalGOTEntry(atom->_atom)) {
+ if (_targetLayout.getGOTSection().hasGlobalGOTEntry(atom->_atom)) {
this->_dynamicSymbolTable->addSymbol(atom->_atom, section->ordinal(),
atom->_virtualAddr, atom);
continue;
@@ -98,7 +98,7 @@ void MipsExecutableWriter<ELFT>::buildDy
// FIXME (simon): Consider to move this check to the
// MipsELFUndefinedAtom class method. That allows to
// handle more complex coditions in the future.
- if (_writeHelper.hasGlobalGOTEntry(a))
+ if (_targetLayout.getGOTSection().hasGlobalGOTEntry(a))
this->_dynamicSymbolTable->addSymbol(a, ELF::SHN_UNDEF);
// Skip our immediate parent class method
More information about the llvm-commits
mailing list