[PATCH] [sanitizer][MIPS] Implement clone for MIPS

Sergey Matveev earthdok at google.com
Thu Apr 2 09:26:00 PDT 2015


Hi, sorry for the delay.

It may be worth adding a note that we don't have proper CFI info here either (same as in x86_64 version). Clang probably supports all the necessary directives now, but it's a lot of code (at least in the mips case) for very marginal benefits, so probably not worth doing.

Note also that the glibc implementation appears to have a few differences between 32 and 64 bit mips, so please double check those to make sure they don't affect us.

Otherwise lgtm.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8318

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list