[PATCH] LLD: ELF: Remove partial class definitions of <Arch>LinkingContexts.

David Blaikie dblaikie at gmail.com
Wed Apr 1 22:29:52 PDT 2015


You're right - this is an ODR violation & your solution looks like it successfully corrects that.

(broader questions about an ideal architecture here - the design here seems a bit awkward - it's trying to avoid any one place including all of the FooLinkingContext.h but instead means we have a header that declares all the functions, so it loses the generality anyway. I'm not sure what a nice generalization would look like - there's always going to be some kind of "all the targets" registration point, likely)


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8797

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list