[PATCH] Add tests for non-virtual call checking.

JF Bastien jfb at chromium.org
Wed Apr 1 17:27:15 PDT 2015


lgtm besides comment.


================
Comment at: test/cfi/nvcall.cpp:51
@@ +50,3 @@
+  break_optimization(new Deriver<B, 2>);
+#endif
+
----------------
Could you add a comment which explain the point of B32/B64/BM? IIUC it's just creating bigger numbers of derived classes, all with a bunch of virtuals?

http://reviews.llvm.org/D8792

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list