[PATCH] [mips] Make sure that we don't adjust the stack pointer by zero amount.
Daniel Sanders
daniel.sanders at imgtec.com
Wed Apr 1 11:17:51 PDT 2015
LGTM with the check for 'Amount == 0' inside adjustStackPtr(). Each caller shouldn't have to check this for itself.
================
Comment at: test/CodeGen/Mips/adjust-callstack-sp.ll:14-16
@@ +13,5 @@
+
+ ; M16-NOT: addiu $sp, 0 # 16 bit inst
+ ; GP32-NOT: addiu $sp, $sp, 0
+ ; GP64-NOT: daddiu $sp, $sp, 0
+ %a = alloca i32, i32 %sz
----------------
Nit: Indentation.
http://reviews.llvm.org/D8638
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list