[PATCH] Add sparc_le architecture (little-endian 32-bit Sparc).

James Y Knight jyknight at google.com
Tue Mar 31 12:05:44 PDT 2015


In the description, you meant to say copied from Sparc V8, right? (as this has created a sparcv8 variant, not a v9 variant).

(and of course some test cases)


================
Comment at: lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp:54
@@ -53,1 +53,3 @@
 
+static MCAsmInfo *createSparc_leMCAsmInfo(const MCRegisterInfo &MRI,
+                                       StringRef TT) {
----------------
Why a new copy of this? Shouldn't it just use createSparcMCAsmInfo?

================
Comment at: lib/Target/Sparc/SparcTargetMachine.cpp:29
@@ +28,3 @@
+static std::string computeDataLayout(const Triple &T,
+				     bool is64Bit, char endianness) {
+  // Sparc is typically big endian, but some are little.
----------------
Perhaps less confusing to just have a bool isLittleEndian instead of a char passed in here?

http://reviews.llvm.org/D8741

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list