[PATCH] Implementation of R_ARM_TARGET1

Leny Kholodov leny.kholodov at gmail.com
Tue Mar 31 11:38:48 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Driver/GnuLdOptions.td:306-312
@@ +305,9 @@
+/// Target Specific Options
+//===----------------------------------------------------------------------===//
+def grp_targetopts : OptionGroup<"opts">,
+     HelpText<"ARCH SPECIFIC OPTIONS">;
+def arm_target1_rel : Flag<["--"], "arm-target1-rel">,
+     Group<grp_targetopts>, HelpText<"Interpret R_ARM_TARGET1 as R_ARM_REL32">;
+def arm_target1_abs : Flag<["--"], "arm-target1-abs">,
+     Group<grp_targetopts>, HelpText<"Interpret R_ARM_TARGET1 as R_ARM_ABS32">;
+
----------------
shankarke wrote:
> I dont see these options in the bfd or the gold linker. Do we need to really have these options ?
> 
> <snip>
> 
> $ ld.bfd --help | grep arm
> $ ld.gold --help | grep arm
>   --fix-arm1176               (ARM only) Fix binaries for ARM1176 erratum.
>   --no-fix-arm1176            (ARM only) Do not fix binaries for ARM1176 erratum.
> 
> </snip>
> 
It uses them without 'arm-' prefix. I've added it to emphasize their architecture specific nature.

http://reviews.llvm.org/D8707

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list