[PATCH] [mips][microMIPSr6] Implement disassembler support

Daniel Sanders daniel.sanders at imgtec.com
Tue Mar 31 05:42:03 PDT 2015


Sorry, I think I missed something.


================
Comment at: lib/Target/Mips/Disassembler/MipsDisassembler.cpp:828
@@ -823,3 +827,3 @@
 
-  if (IsMicroMips) {
+  if (IsMicroMips || hasMicroMips32r6()) {
     Result = readInstruction16(Bytes, Address, Size, Insn, IsBigEndian);
----------------
Do we need both here? I'd expect IsMicroMips to be true when hasMicroMips32r6() is true. It may be better to move the hasMicroMips32r6() check to the else on line 849.

http://reviews.llvm.org/D8490

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list