[PATCH] [lld][ELF][ARM] Generate PLT entries for function calls from ARM and Thumb code

[Denis Protivensky]

Thanks for reviewing, Rui!


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:125
@@ -122,2 +124,3 @@
 class ARMGOTAtom : public GOTAtom {
-public:
+protected:
+  // Constructor for PLTGOT atom.
----------------
ruiu wrote:
> We usually put protected members after public members. You may want to move this for consistency.
Didn't want to move the constructor to the bottom of the class, but that's not a big deal. Will do.

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:378
@@ -302,1 +377,3 @@
+#else
+        StringRef();
 #endif
----------------
ruiu wrote:
> Maybe this is enough?
> 
>   StringRef source;
>   #ifndef NDEBUG
>   source = "_ifunc_";
>   #endif
> 
Right.

http://reviews.llvm.org/D8701

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/