[PATCH] Fix WinEHPrepare bug with multiple catch handlers

Reid Kleckner rnk at google.com
Mon Mar 30 17:34:55 PDT 2015


Here's an idea. What if before outlining, we run mem2reg (see `llvm::PromoteMemToReg`) on all EH value objects? This should greatly simplify the existing preparation code, because we won't need to track stores of selectors and EH pointers anymore. Even at -O0, these allocas are not visible to the user, so removing them is useful. If the frontend produces IR that fails to promote, I think it's totally reasonable for WinEHPrepare to assert.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8682

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list