[PATCH] Add support for lldb remote test
Chaoren Lin
chaorenl at google.com
Mon Mar 30 15:24:31 PDT 2015
Please see comments below:
================
Comment at: buildbot/osuosl/master/config/builders.py:724
@@ -723,1 +723,3 @@
test_compilers=['clang', 'totclang', 'gcc4.8.2'],
+ remote_ip="173.255.116.181",
+ remote_dir="/lldb-buildbot/remotetest",
----------------
Does this have to be hardcoded? You should probably use a hostname instead if it must be hardcoded.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:266
@@ +265,3 @@
+ f.addStep(ShellCommand(name="launch lldb-server",
+ command="ssh %s screen -d -m %s/lldb-server platform --listen *:5432 --server" % (remote_ip, remote_dir),
+ description="launch lldb-server on remote host",
----------------
> screen -d -m
Why not `ssh -f`?
> --listen *:5432
Is this remote machine accessible from anywhere besides the build machine? If you know the hostname of the build machine, you should probably use that instead of `*`. Also, must the port be hardcoded?
http://reviews.llvm.org/D8711
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list