[PATCH] [Sanitizer RT] Put the module name string ownership in Symbolizer in order

Kostya Serebryany kcc at google.com
Mon Mar 30 12:45:38 PDT 2015


In http://reviews.llvm.org/D8666#148920, @timurrrr wrote:

> Like this?


Yea.. This clearly sucks too. Probably more than you initial variant. 
Let's get back to it and polish it.

> Please note we have a warning if a function takes more than 512 bytes on stack, so I used `InternalScopedString` instead.  This implies `mmap`+`munmap` on each TU on process startup, plus a few times on shutdown.  I've tried the patch on `pdfium_test` and `chrome` and haven't observed much slowdown...

> 

> [TODO: update subject before comitting]





http://reviews.llvm.org/D8666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list