[PATCH] Early expansion of MUX instructions on Hexagon

Quentin Colombet qcolombet at apple.com
Mon Mar 30 12:30:39 PDT 2015


LGTM for the update liveness part.

I cannot comment on the hexagon-specific aspect of the patch.

Cheers,
-Quentin


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/Hexagon/HexagonExpandCondsets.cpp:257
@@ +256,3 @@
+/// going on, predicated instructions will have implicit uses of the re-
+/// gisters that are being defined. This is to keep any preceding defini-
+/// tions live. If there is no preceding definition, the implicit use will
----------------
We usually do not use hyphens in comments.

http://reviews.llvm.org/D8329

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list