[PATCH] ScheduleDAGInstrs::buildSchedGraph() rewritten.

Andrew Trick atrick at apple.com
Mon Mar 30 10:37:24 PDT 2015


This looks like a great improvement except for all the data structure boilerplate in the header. I'll take it on your word and Hal's review that the functionality is preserved and that compile time is positively impacted.


================
Comment at: include/llvm/CodeGen/ScheduleDAGInstrs.h:153
@@ +152,3 @@
+   /// A list of SUnits, used in Value2SUsMap, during DAG construction.
+    class SUList {
+      /// std::list is faster than SmallVector, and SparseSet is not
----------------
I don't really understand the value of wrapping the std::list API. Can't you just use a typedef or expose the underlying list?

================
Comment at: include/llvm/CodeGen/ScheduleDAGInstrs.h:157
@@ +156,3 @@
+      /// with a memory pool.
+      std::list<SUnit *> l;
+
----------------
Uppercase variable name.

http://reviews.llvm.org/D8705

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list