[PATCH] [PGO] Hoist hot case statement from switches

Daniel Jasper djasper at google.com
Mon Mar 30 10:00:22 PDT 2015


Hans is probably best-suited to review this properly. However, also note that he is undertaking a massive rewrite of the entire switch lowering logic (http://reviews.llvm.org/D8649). You should probably sync.

As for the approach, I am not entirely sure if it is good. Obviously, we want to make use of profile numbers to improve switch lowering. However, it is unclear to me whether e.g. we'd want to handle the hot case separately, even if it could be part of a jump table instead. Jump tables are quite fast and pulling the hot case out is additional, entirely additional code.


http://reviews.llvm.org/D5786

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list