[llvm] r231227 - Fix PR22408 - LLVM producing AArch64 TLS relocations that GNU linkers cannot handle yet.

Kristof Beyls kristof.beyls at arm.com
Mon Mar 30 07:41:11 PDT 2015


Hi Ed, Tim, Tom,

The attached patch is a backport of r229195 to the 3.6 release branch.
There were only very minor merge conflicts.

I've tested this backport locally on AArch64-linux: it allows to build
top-of-trunk LLVM with 3.6, whereas without this patch it doesn't.

Ed: you said you could also run some more testing on this patch?

Tim, Tom: any reason not to commit the attached patch to the 3.6
release branch?

Thanks,

Kristof


> -----Original Message-----
> From: Gabor Ballabas [mailto:gaborb at inf.u-szeged.hu]
> Sent: 26 March 2015 14:16
> To: llvm-commits at cs.uiuc.edu
> Cc: Kristof Beyls; 'Ed Maste'; Tim Northover; tom at stellard.net
> Subject: Re: [llvm] r231227 - Fix PR22408 - LLVM producing AArch64 TLS
> relocations that GNU linkers cannot handle yet.
> 
> Hi Kristof,
> 
> No, the only reason for this patch was that linker issue.
> If that has been solved than r229195 can be safely reverted.
> 
> 
> Best regards,
> Gabor Ballabas
> 
> On 03/25/2015 07:57 AM, Kristof Beyls wrote:
> > Hi Ed,
> >
> > Thanks for prodding.
> >
> > I was waiting for the work-around of the issue fixed by this patch on
> > the http://lab.llvm.org:8011/builders/clang-native-aarch64-full
> > buildbot (see
> > http://llvm.org/viewvc/llvm-project?view=revision&revision=229195)
> > to be reverted to have one additional confirmation that this commit is
> > fixing the problem before pushing on and getting this backported to
> the 3.6 branch.
> >
> > Gabor, do you see any reason not to revert
> http://llvm.org/viewvc/llvm-project?view=revision&revision=229195?
> >
> > Thanks,
> >
> > Kristof
> >
> >> -----Original Message-----
> >> From: carpeddiem at gmail.com [mailto:carpeddiem at gmail.com] On Behalf Of
> >> Ed Maste
> >> Sent: 24 March 2015 18:27
> >> To: Kristof Beyls
> >> Cc: llvm-commits at cs.uiuc.edu
> >> Subject: Re: [llvm] r231227 - Fix PR22408 - LLVM producing AArch64
> >> TLS relocations that GNU linkers cannot handle yet.
> >>
> >> On 4 March 2015 at 04:12, Kristof Beyls <kristof.beyls at arm.com>
> wrote:
> >>> Author: kbeyls
> >>> Date: Wed Mar  4 03:12:08 2015
> >>> New Revision: 231227
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=231227&view=rev
> >>> Log:
> >>> Fix PR22408 - LLVM producing AArch64 TLS relocations that GNU
> >>> linkers
> >> cannot handle yet.
> >>
> >> Any chance of bringing this back to 3.6 for the eventual 3.6.1? For
> >> us in FreeBSD at least we've run into this on our system compiler
> >> (3.6.0) and would like to bring this in. As it turns out it doesn't
> >> apply cleanly, so if you have plans to backport it we'll pull it from
> there.
> >
> >
> >



-------------- next part --------------
A non-text attachment was scrubbed...
Name: PR22408-36.patch
Type: application/octet-stream
Size: 34698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150330/753c12be/attachment.obj>


More information about the llvm-commits mailing list