[PATCH] [OPENMP] llvm.loop.vectorize.enable metadata are lost after critical edge splitting

Daniel Berlin dberlin at dberlin.org
Sun Mar 29 13:55:59 PDT 2015


Err, shouldn't loopinfo just be preserved here rather than required, like BreakCriticalEdges does?
If llvm.loop.vectorize.enable is considered part of the loopinfo pass, adding it as preserved and updating it if available, should have zero cost, unlike making it required.

SplitCriticalEdge already can take LoopInfo as an option nowadays, (see Options.LI), so you don't need to add it again.  SplitCriticalEdge is already using it to maintain loopsimplify form.  You should just update it if it's around


http://reviews.llvm.org/D5539

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list