[PATCH] [PATCH][SROA]Also slice the STORE when slicing a LOAD in AllocaSliceRewriter

Chandler Carruth chandlerc at gmail.com
Sun Mar 29 13:25:15 PDT 2015


I don't think this patch is correct. I think the IR formulation is the correct formulation.

We have worked very hard to not slice stores, and I think we should continue to do so where tractable. The cases in this test seem quite reasonable to lower is a single store.

If lowering on a particular platform is faster with two stores rather than one store, we should do that in the backend. We could even create target independent code to do this and let each target opt into it. The IR should preserve the wide store though as that provides strictly more information to the backend about the set of possible lowering strategies.


http://reviews.llvm.org/D4954

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list