[lld] r233436 - ELF: Make addSearchPath return void instead of bool.

Rui Ueyama ruiu at google.com
Fri Mar 27 15:20:21 PDT 2015


Author: ruiu
Date: Fri Mar 27 17:20:21 2015
New Revision: 233436

URL: http://llvm.org/viewvc/llvm-project?rev=233436&view=rev
Log:
ELF: Make addSearchPath return void instead of bool.

No one uses return value of the member function, and return value
is always true. Returning a value doesn't make sense.
This patch also de-virtualize the fucntion.

Modified:
    lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h

Modified: lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h?rev=233436&r1=233435&r2=233436&view=diff
==============================================================================
--- lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h (original)
+++ lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h Fri Mar 27 17:20:21 2015
@@ -262,10 +262,7 @@ public:
   }
 
   // add search path to list.
-  virtual bool addSearchPath(StringRef ref) {
-    _inputSearchPaths.push_back(ref);
-    return true;
-  }
+  void addSearchPath(StringRef ref) { _inputSearchPaths.push_back(ref); }
 
   // Retrieve search path list.
   StringRefVector getSearchPaths() { return _inputSearchPaths; };





More information about the llvm-commits mailing list