[PATCH] [MCInstPrinter] Enable MCInstPrinter to change its behavior based on the per-function subtarget

Eric Christopher echristo at gmail.com
Fri Mar 27 13:21:16 PDT 2015


On Fri, Mar 27, 2015 at 1:14 PM Akira Hatanaka <ahatanak at gmail.com> wrote:

> Thanks.
>
> I wasn't planning to make the changes I made for AArch64 for other ports
> that don't use subtarget feature bits in their instprinters, but if it's
> important to have a uniform interface for the print methods table-gen
> generates, I can update those ports later and remove PassSubtarget.
>
>
Yeah. More of a long term code cleanliness FIXME than anything else.

-eric


> In http://reviews.llvm.org/D8668#148039, @echristo wrote:
>
> > Excellent. We're in agreement then.
> >
> > One inline comment and then LGTM.
> >
> > -eric
>
>
>
>
>
> http://reviews.llvm.org/D8668
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150327/362ec7c6/attachment.html>


More information about the llvm-commits mailing list