[PATCH] [Sanitizer RT] Put the module name string ownership in Symbolizer in order

Timur Iskhodzhanov timurrrr at google.com
Fri Mar 27 12:37:01 PDT 2015


>> How does the caller pick the buffer size?
>
> isn't this kMaxPathLength ?

Yes, probably :)

>>   Also, this way we'll be copying a lot of strings without the need to do so...
>
> How bad is that?
> Are we getting the module name in any perf critical place?

I haven't measured that yet, but I think it's basically once for each
TU in the default coverage mode.
Possibly more for edge coverage?



More information about the llvm-commits mailing list