[PATCH] [Sanitizer RT] Put the module name string ownership in Symbolizer in order

Kostya Serebryany kcc at google.com
Fri Mar 27 11:08:45 PDT 2015


================
Comment at: sanitizer_symbolizer.cc:78
@@ -77,1 +77,3 @@
 
+Symbolizer::ModuleNameOwner::~ModuleNameOwner() {
+  for (uptr i = 0; i < storage_.size(); ++i)
----------------
timurrrr wrote:
> kcc wrote:
> > Why do you need a DTOR? 
> > Are you ever going to call it except for when the process is dying? 
> Correct.  Should I remove it?
Yes, if we decide to proceed with this, but I'd prefer we don't

http://reviews.llvm.org/D8666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list