[PATCH] [mips] Implement eliminateCallFramePseudoInstr() in MipsFrameLowering. NFC.

Eric Christopher echristo at gmail.com
Thu Mar 26 12:44:26 PDT 2015


Random drive by comment. The rest LGTM.

-eric


================
Comment at: lib/Target/Mips/MipsFrameLowering.cpp:139
@@ +138,3 @@
+                              MachineBasicBlock::iterator I) const {
+  unsigned SP = STI.isABI_N64() ? Mips::SP_64 : Mips::SP;
+
----------------
Should probably get the ABI off of the TargetMachine. I'd like to (or someone should)  remove the subtarget ones at some point and migrate everything to using TM for them.

http://reviews.llvm.org/D8641

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list