[llvm] r233309 - [ARM] Fix some non-portable shell syntax in r233301's tests

Justin Bogner mail at justinbogner.com
Thu Mar 26 12:24:14 PDT 2015


Author: bogner
Date: Thu Mar 26 14:24:13 2015
New Revision: 233309

URL: http://llvm.org/viewvc/llvm-project?rev=233309&view=rev
Log:
[ARM] Fix some non-portable shell syntax in r233301's tests

The "|&" operator isn't POSIX, so it can fail depending on the host's
default shell. Avoid it.

There were also a couple of places that did "2>1", but this creates a
file called "1". They clearly meant "2>&1".

Modified:
    llvm/trunk/test/MC/ARM/basic-arm-instructions-v8.1a.s
    llvm/trunk/test/MC/Disassembler/ARM/thumb-v8.1a.txt

Modified: llvm/trunk/test/MC/ARM/basic-arm-instructions-v8.1a.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/basic-arm-instructions-v8.1a.s?rev=233309&r1=233308&r2=233309&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/basic-arm-instructions-v8.1a.s (original)
+++ llvm/trunk/test/MC/ARM/basic-arm-instructions-v8.1a.s Thu Mar 26 14:24:13 2015
@@ -3,8 +3,8 @@
 //RUN: not llvm-mc -triple arm-none-linux-gnu -mattr=+v8.1a -mattr=neon -show-encoding < %s 2>%t | FileCheck %s --check-prefix=CHECK-V81aARM
 //RUN: FileCheck --check-prefix=CHECK-ERROR <%t %s
 
-//RUN: not llvm-mc -triple thumb-none-linux-gnu -mattr=+v8 -mattr=neon -show-encoding < %s 2>1 |& FileCheck %s --check-prefix=CHECK-V8
-//RUN: not llvm-mc -triple arm-none-linux-gnu -mattr=+v8 -mattr=neon -show-encoding < %s 2>1 |& FileCheck %s --check-prefix=CHECK-V8
+//RUN: not llvm-mc -triple thumb-none-linux-gnu -mattr=+v8 -mattr=neon -show-encoding < %s 2>&1 | FileCheck %s --check-prefix=CHECK-V8
+//RUN: not llvm-mc -triple arm-none-linux-gnu -mattr=+v8 -mattr=neon -show-encoding < %s 2>&1 | FileCheck %s --check-prefix=CHECK-V8
 
 
   .text

Modified: llvm/trunk/test/MC/Disassembler/ARM/thumb-v8.1a.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Disassembler/ARM/thumb-v8.1a.txt?rev=233309&r1=233308&r2=233309&view=diff
==============================================================================
--- llvm/trunk/test/MC/Disassembler/ARM/thumb-v8.1a.txt (original)
+++ llvm/trunk/test/MC/Disassembler/ARM/thumb-v8.1a.txt Thu Mar 26 14:24:13 2015
@@ -1,5 +1,5 @@
-# RUN: llvm-mc -triple thumbv8 -mattr=+v8.1a  --disassemble < %s |& FileCheck %s --check-prefix=CHECK-V81a
-# RUN: not llvm-mc -triple thumbv8 -mattr=+v8 --disassemble < %s |& FileCheck %s --check-prefix=CHECK-V8
+# RUN: llvm-mc -triple thumbv8 -mattr=+v8.1a  --disassemble < %s 2>&1 | FileCheck %s --check-prefix=CHECK-V81a
+# RUN: not llvm-mc -triple thumbv8 -mattr=+v8 --disassemble < %s 2>&1 | FileCheck %s --check-prefix=CHECK-V8
 
 [0x11,0xff,0x12,0x0b]
 # CHECK-V81a: vqrdmlah.s16  d0, d1, d2





More information about the llvm-commits mailing list